[PATCH] D11131: [ARM] Add Thumb2 ADD with SP narrowing from 3 operand to 2
Renato Golin
renato.golin at linaro.org
Mon Jul 13 06:28:17 PDT 2015
rengolin added a comment.
In http://reviews.llvm.org/D11131#203644, @scott-0 wrote:
> Thanks for the review!
>
> There is 'add sp, sp, #4' in basic-thumb-instructions.s and 'add sp, sp, #0x1fe0000' in basic-thumb2-instructions.s
Just about the transformation, in this test-file, if you had the allowed imm for SP transformed and the not-allowed not transformed, that'd be enough, I think.
> but I thought it was a bit easier to follow with the intermediate steps.
It is. :)
http://reviews.llvm.org/D11131
More information about the llvm-commits
mailing list