[PATCH] D11076: [ELF/AArch64] Fix export TLS dynamic symbol
Adhemerval Zanella
adhemerval.zanella at linaro.org
Thu Jul 9 14:55:42 PDT 2015
On 09-07-2015 16:01, Rui Ueyama wrote:
> ruiu added inline comments.
>
> ================
> Comment at: lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.cpp:37
> @@ +36,3 @@
> + auto gotSections = _targetLayout.getGOTSections();
> + std::for_each(gotSections.begin(), gotSections.end(), [&](AArch64GOTBaseSection *gotSection) {
> + if (gotSection->hasGlobalGOTEntry(atom->_atom)) {
> ----------------
> Why std::for_each? Can you use regular for loop instead?
>
I can, I will change it.
>
> http://reviews.llvm.org/D11076
>
>
>
More information about the llvm-commits
mailing list