[PATCH] D11076: [ELF/AArch64] Fix export TLS dynamic symbol

Rui Ueyama ruiu at google.com
Thu Jul 9 12:01:57 PDT 2015


ruiu added inline comments.

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.cpp:37
@@ +36,3 @@
+        auto gotSections = _targetLayout.getGOTSections();
+        std::for_each(gotSections.begin(), gotSections.end(), [&](AArch64GOTBaseSection *gotSection) {
+          if (gotSection->hasGlobalGOTEntry(atom->_atom)) {
----------------
Why std::for_each? Can you use regular for loop instead?


http://reviews.llvm.org/D11076







More information about the llvm-commits mailing list