[PATCH] D11053: [ARM] Add ADD tests for Thumb2 narrowing (nfc)

[scott douglass]

scott-0 added a comment.

Thanks for the review!


================
Comment at: test/MC/ARM/thumb2-narrow-dp.ll:67
@@ +66,3 @@
+    ADD      r3, r3, r1          // T2
+// CHECK: add  r3, r1               @ encoding: [0x0b,0x44]
+
----------------
rengolin wrote:
> Not testing for higher registers in T2/T3? Or conditional T2?
I didn't include them because the 3-to-2 operand narrowing doesn't affect them.  I'm happy to add them to make this file more complete.  Hireg T2 and T3 are already tested in basic-thumb2-instructions.s (line 119+, hireg T2 and T3).

I can't find a test for conditional T2.  I'm happy to add one, but I think it would fit best in same part of basic-thumb2-instructions.s.

================
Comment at: test/MC/ARM/thumb2-narrow-dp.ll:78
@@ +77,3 @@
+    ADD      sp, sp, r10         // T2
+// CHECK: add   sp, r10             @ encoding: [0xd5,0x44]
+
----------------
rengolin wrote:
> Not testing T1/3/4? Conditionals?
I can add some to basic-thumb2-instructions.s.

And, I'm happy to add them here, too, if you think that's best.



http://reviews.llvm.org/D11053