[PATCH] D11053: [ARM] Add ADD tests for Thumb2 narrowing (nfc)

Renato Golin renato.golin at linaro.org
Thu Jul 9 03:31:57 PDT 2015


rengolin added inline comments.

================
Comment at: test/MC/ARM/thumb2-narrow-dp.ll:67
@@ +66,3 @@
+    ADD      r3, r3, r1          // T2
+// CHECK: add  r3, r1               @ encoding: [0x0b,0x44]
+
----------------
Not testing for higher registers in T2/T3? Or conditional T2?

================
Comment at: test/MC/ARM/thumb2-narrow-dp.ll:78
@@ +77,3 @@
+    ADD      sp, sp, r10         // T2
+// CHECK: add   sp, r10             @ encoding: [0xd5,0x44]
+
----------------
Not testing T1/3/4? Conditionals?


http://reviews.llvm.org/D11053







More information about the llvm-commits mailing list