[PATCH] D10835: getStrideFromPointer and its helper function from LoopVectorize moved to VectorUtils

[Nema, Ashutosh]

>> > Incorporated comments from Hal.
>>
>>
>> Hi Hal,
>>
>> Does this looks OK to you ?
>
>Yes, LGTM (with one small change in  a comment requested below).

Thanks Hal, I'll change it.

Thanks,
Ashutosh

-----Original Message-----
From: hfinkel at anl.gov [mailto:hfinkel at anl.gov] 
Sent: Thursday, July 09, 2015 9:57 AM
To: Nema, Ashutosh; charlie.turner at arm.com; dblaikie at gmail.com; listmail at philipreames.com; hfinkel at anl.gov
Cc: david.majnemer at gmail.com; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] D10835: getStrideFromPointer and its helper function from LoopVectorize moved to VectorUtils

hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D10835#201534, @ashutosh.nema wrote:

> > Incorporated comments from Hal.
>
>
> Hi Hal,
>
> Does this looks OK to you ?


Yes, LGTM (with one small change in  a comment requested below).

> Thanks,

> Ashutosh





================
Comment at: include/llvm/Analysis/VectorUtils.h:74
@@ +73,3 @@
+/// \brief Get the stride of a pointer access in a loop. Looks for symbolic
+/// strides "a[i*stride]". Returns the symbolic stride as Value, or null 
+/// otherwise.
----------------
remove "as Value" (I think it reads oddly, as is obvious from the signature)

================
Comment at: lib/Analysis/VectorUtils.cpp:283
@@ +282,3 @@
+/// \brief Get the stride of a pointer access in a loop. Looks for symbolic
+/// strides "a[i*stride]". Returns the symbolic stride as Value, or null
+/// otherwise.
----------------
Same here.


Repository:
  rL LLVM

http://reviews.llvm.org/D10835