[PATCH] D10835: getStrideFromPointer and its helper function from LoopVectorize moved to VectorUtils

[hfinkel at anl.gov]

hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D10835#201534, @ashutosh.nema wrote:

> > Incorporated comments from Hal.
>
>
> Hi Hal,
>
> Does this looks OK to you ?


Yes, LGTM (with one small change in  a comment requested below).

> Thanks,

> Ashutosh





================
Comment at: include/llvm/Analysis/VectorUtils.h:74
@@ +73,3 @@
+/// \brief Get the stride of a pointer access in a loop. Looks for symbolic
+/// strides "a[i*stride]". Returns the symbolic stride as Value, or null 
+/// otherwise.
----------------
remove "as Value" (I think it reads oddly, as is obvious from the signature)

================
Comment at: lib/Analysis/VectorUtils.cpp:283
@@ +282,3 @@
+/// \brief Get the stride of a pointer access in a loop. Looks for symbolic
+/// strides "a[i*stride]". Returns the symbolic stride as Value, or null
+/// otherwise.
----------------
Same here.


Repository:
  rL LLVM

http://reviews.llvm.org/D10835