[PATCH] D11037: Make TargetLowering::getShiftAmountTy() taking DataLayout as an argument

Eric Christopher echristo at gmail.com
Wed Jul 8 17:39:16 PDT 2015


echristo added inline comments.

================
Comment at: include/llvm/Target/TargetLowering.h:174
@@ -173,3 +173,3 @@
   }
-  virtual MVT getScalarShiftAmountTy(EVT LHSTy) const;
+  virtual MVT getScalarShiftAmountTy(EVT LHSTy, const DataLayout &DL) const;
 
----------------
joker.eph wrote:
> echristo wrote:
> > Can you make sure the position of the DataLayout argument is consistent while you do this? (See above with getPointerTy).
> Sure!
> 
> Doing it I realized that the other parameter (`EVT LHSTy`) is never used, should I remove it?
Yep!


http://reviews.llvm.org/D11037







More information about the llvm-commits mailing list