[PATCH] D11037: Make TargetLowering::getShiftAmountTy() taking DataLayout as an argument

Mehdi AMINI mehdi.amini at apple.com
Wed Jul 8 17:32:56 PDT 2015


joker.eph added inline comments.

================
Comment at: include/llvm/Target/TargetLowering.h:174
@@ -173,3 +173,3 @@
   }
-  virtual MVT getScalarShiftAmountTy(EVT LHSTy) const;
+  virtual MVT getScalarShiftAmountTy(EVT LHSTy, const DataLayout &DL) const;
 
----------------
echristo wrote:
> Can you make sure the position of the DataLayout argument is consistent while you do this? (See above with getPointerTy).
Sure!

Doing it I realized that the other parameter (`EVT LHSTy`) is never used, should I remove it?


http://reviews.llvm.org/D11037







More information about the llvm-commits mailing list