[PATCH] D10969: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

[Eric Christopher]

Wait, can you give a rundown of what your TargetTuple is doing etc? Maybe a
mail to the list? This seems weird.

Thanks!

-eric

On Tue, Jul 7, 2015 at 8:13 AM Daniel Sanders <daniel.sanders at imgtec.com>
wrote:

> > About the Tuple+CPU+Features (and others), unless you're planning to do
> that move in this streak, I think it'd be best to keep a small FIXME
> comment to use CPU/Features/Options in the Tuple itself.
>
>
> I'm not planning to merge CPU name and Features into the TargetTuple in
> this series, but I probably should do this at some point. I'll add some
> FIXME's for now
>
>
> ================
> Comment at: include/llvm/Support/TargetRegistry.h:119
> @@ -117,1 +118,3 @@
> +                                              const TargetTuple &TT,
> +                                              StringRef CPU);
>    typedef MCTargetAsmParser *(*MCAsmParserCtorTy)(
> ----------------
> rengolin wrote:
> > I think this one deserves a FIXME. CPU should be already uniquely
> identifiable in the tuple.
> > CPU should be already uniquely identifiable in the tuple.
>
> I don't think that's true at the moment since Triples/TargetTuples lack
> the variety of values that the CPU name has. For example, -mcpu=pentium
> would cause CPU to be 'pentium' but the Triple/TargetTuple doesn't know
> about this string.
>
> Are you thinking of the SubArch field that ARM and Kalimba use?
>
>
> http://reviews.llvm.org/D10969
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150707/996fad7f/attachment.html>