[PATCH] D10969: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

Daniel Sanders daniel.sanders at imgtec.com
Tue Jul 7 08:06:33 PDT 2015


> About the Tuple+CPU+Features (and others), unless you're planning to do that move in this streak, I think it'd be best to keep a small FIXME comment to use CPU/Features/Options in the Tuple itself.


I'm not planning to merge CPU name and Features into the TargetTuple in this series, but I probably should do this at some point. I'll add some FIXME's for now


================
Comment at: include/llvm/Support/TargetRegistry.h:119
@@ -117,1 +118,3 @@
+                                              const TargetTuple &TT,
+                                              StringRef CPU);
   typedef MCTargetAsmParser *(*MCAsmParserCtorTy)(
----------------
rengolin wrote:
> I think this one deserves a FIXME. CPU should be already uniquely identifiable in the tuple.
> CPU should be already uniquely identifiable in the tuple.

I don't think that's true at the moment since Triples/TargetTuples lack the variety of values that the CPU name has. For example, -mcpu=pentium would cause CPU to be 'pentium' but the Triple/TargetTuple doesn't know about this string.

Are you thinking of the SubArch field that ARM and Kalimba use?


http://reviews.llvm.org/D10969







More information about the llvm-commits mailing list