[PATCH] Improve testing for the C API

Duncan P. N. Exon Smith dexonsmith at apple.com
Sat Jun 27 10:33:00 PDT 2015


> On 2015 Jun 24, at 22:45, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> So, I really like this as a way to ensure we have reasonable binding coverage of IR manipulation. But I'd like to hear others' opinions.

Seems reasonable!

> If we're going this direction, as discussed in IRC, i'd try to come up with a nice pattern so we don't have to manually CHECK everything.
> 
> I'd also like to float the idea of writing the code for this in C++, and just restricting it to interface via the C API.

+1 for C++.

> I think that would make the code here a lot cleaner and simpler. We can still use extern "C" to wire it into main.c. As part of that, I'd pick a naming convention and stick to it. My preference is to use C++ and use the LLVM naming convention consistently here. We can update the rest of llvm-c-test as we go.
> 
> Finally, running clang-format over it would be nice.
> 
> 
> http://reviews.llvm.org/D10725
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list