[PATCH] Improve testing for the C API

Chandler Carruth chandlerc at gmail.com
Wed Jun 24 22:45:43 PDT 2015


So, I really like this as a way to ensure we have reasonable binding coverage of IR manipulation. But I'd like to hear others' opinions.

If we're going this direction, as discussed in IRC, i'd try to come up with a nice pattern so we don't have to manually CHECK everything.

I'd also like to float the idea of writing the code for this in C++, and just restricting it to interface via the C API. I think that would make the code here a lot cleaner and simpler. We can still use extern "C" to wire it into main.c. As part of that, I'd pick a naming convention and stick to it. My preference is to use C++ and use the LLVM naming convention consistently here. We can update the rest of llvm-c-test as we go.

Finally, running clang-format over it would be nice.


http://reviews.llvm.org/D10725

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list