LGTM ================ Comment at: lib/tsan/rtl/tsan_suppressions.cc:98 @@ -96,1 +97,3 @@ +uptr IsSuppressed(const char *stype, const AddressInfo &info, + Suppression **sp) { ---------------- make this function static? http://reviews.llvm.org/D10686 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/