[PATCH] tsan: implement suppressions for top frame only
Dmitry Vyukov
dvyukov at google.com
Thu Jun 25 05:00:30 PDT 2015
ptal
================
Comment at: lib/tsan/rtl/tsan_suppressions.cc:110
@@ -108,3 +109,3 @@
const AddressInfo &info = frame->info;
if (suppression_ctx->Match(info.function, stype, &s) ||
suppression_ctx->Match(info.file, stype, &s) ||
----------------
samsonov wrote:
> you can totally factor this out to
> bool IsSuppressed(const AddressInfo &info, const char *suppression_type, Suppression **sp);
done
================
Comment at: lib/tsan/rtl/tsan_suppressions.cc:119
@@ -117,1 +118,3 @@
}
+ if (0 == internal_strcmp(stype, kSuppressionRace) && stack->frames != 0) {
+ const AddressInfo &info = stack->frames->info;
----------------
samsonov wrote:
> stack->frames != nullptr
done
================
Comment at: test/tsan/race_top_suppression.cc.supp:1
@@ +1,1 @@
+race_top:TopFunction
----------------
samsonov wrote:
> I'd prefer to get rid of extra file, and create it with "echo" command in the RUN-line.
done
http://reviews.llvm.org/D10686
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list