[llvm] r240439 - Don't pass a 32 bit value to "%08" PRIx64.

Sean Silva chisophugis at gmail.com
Wed Jun 24 18:41:29 PDT 2015


For the future, we have format_hex and friends in Support/Format.h

-- Sean Silva

On Tue, Jun 23, 2015 at 11:34 AM, Rafael Espindola <
rafael.espindola at gmail.com> wrote:

> Author: rafael
> Date: Tue Jun 23 13:34:25 2015
> New Revision: 240439
>
> URL: http://llvm.org/viewvc/llvm-project?rev=240439&view=rev
> Log:
> Don't pass a 32 bit value to "%08" PRIx64.
>
> Should fix the arm bots.
>
> Modified:
>     llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
>
> Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=240439&r1=240438&r2=240439&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
> +++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Tue Jun 23 13:34:25 2015
> @@ -1148,10 +1148,10 @@ void llvm::PrintSymbolTable(const Object
>      }
>
>      outs() << '\t';
> -    if (Common)
> -      outs() << format("%08" PRIx64 " ", Symbol.getAlignment());
> -    else if (isa<ELFObjectFileBase>(o))
> -      outs() << format("%08" PRIx64 " ", Symbol.getSize());
> +    if (Common || isa<ELFObjectFileBase>(o)) {
> +      uint64_t Val = Common ? Symbol.getAlignment() :  Symbol.getSize();
> +      outs() << format("\t %08" PRIx64 " ", Val);
> +    }
>
>      if (Hidden) {
>        outs() << ".hidden ";
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150624/e881d068/attachment.html>


More information about the llvm-commits mailing list