<div dir="ltr">For the future, we have format_hex and friends in Support/Format.h<div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 23, 2015 at 11:34 AM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Jun 23 13:34:25 2015<br>
New Revision: 240439<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240439-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=zajEFN7KdLcTGRSnirjrS3Pt_1xCROwW7S9we3_47VY&s=3S5YnvxtqbnZKqe-BMGwPNhp3wovz1vNvkZUvgv70JA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=240439&view=rev</a><br>
Log:<br>
Don't pass a 32 bit value to "%08" PRIx64.<br>
<br>
Should fix the arm bots.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_tools_llvm-2Dobjdump_llvm-2Dobjdump.cpp-3Frev-3D240439-26r1-3D240438-26r2-3D240439-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=zajEFN7KdLcTGRSnirjrS3Pt_1xCROwW7S9we3_47VY&s=bnp14KBSXJIv2rkP6Y1Mpu_yAwPVDUpco614xzBT1SA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=240439&r1=240438&r2=240439&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)<br>
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Tue Jun 23 13:34:25 2015<br>
@@ -1148,10 +1148,10 @@ void llvm::PrintSymbolTable(const Object<br>
     }<br>
<br>
     outs() << '\t';<br>
-    if (Common)<br>
-      outs() << format("%08" PRIx64 " ", Symbol.getAlignment());<br>
-    else if (isa<ELFObjectFileBase>(o))<br>
-      outs() << format("%08" PRIx64 " ", Symbol.getSize());<br>
+    if (Common || isa<ELFObjectFileBase>(o)) {<br>
+      uint64_t Val = Common ? Symbol.getAlignment() :  Symbol.getSize();<br>
+      outs() << format("\t %08" PRIx64 " ", Val);<br>
+    }<br>
<br>
     if (Hidden) {<br>
       outs() << ".hidden ";<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>