[PATCH] [LoopVectorize] Detect correctly if vectorizer will create a tail loop

Mikhail Zolotukhin mzolotukhin at apple.com
Wed Jun 24 10:33:27 PDT 2015


Hi Marianne!

I committed your patch in r240556 with a small change in the test:
-; RUN: opt < %s -loop-vectorize -O2 -debug -S 2>&1 | FileCheck %s
+; REQUIRES: asserts
+; RUN: opt < %s -loop-vectorize -Os -debug -debug-only=loop-vectorize -S 2>&1 | FileCheck %s

Thanks for fixing it!

Michael

> On Jun 23, 2015, at 6:34 AM, Marianne Mailhot-Sarrasin <marianne.mailhot-sarrasin at octasic.com> wrote:
> 
> Thanks. Could you please commit it ?
>  
> Marianne
>  
> From: Nadav Rotem [mailto:nrotem at apple.com] 
> Sent: June-22-15 6:25 PM
> To: Marianne Mailhot-Sarrasin
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] [LoopVectorize] Detect correctly if vectorizer will create a tail loop
>  
> Looks good to me. 
>  
>  
> On Jun 22, 2015, at 12:17 PM, Marianne Mailhot-Sarrasin <marianne.mailhot-sarrasin at octasic.com <mailto:marianne.mailhot-sarrasin at octasic.com>> wrote:
>  
> I have added it in the patch.
>  
> From: Nadav Rotem [mailto:nrotem at apple.com <mailto:nrotem at apple.com>] 
> Sent: June-22-15 1:21 PM
> To: Marianne Mailhot-Sarrasin
> Cc: llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> Subject: Re: [PATCH] [LoopVectorize] Detect correctly if vectorizer will create a tail loop
>  
> Hi Marianne, 
>  
> Can you please provide a testcase for this fix?
>  
> Thanks,
> Nadav
>  
>  
> On Jun 22, 2015, at 7:01 AM, Marianne Mailhot-Sarrasin <marianne.mailhot-sarrasin at octasic.com <mailto:marianne.mailhot-sarrasin at octasic.com>> wrote:
>  
> Hi,
>  
> Here is a simple bug fix. With option OptForSize enabled, the Loop Vectorizer is not supposed to create tail loop. The condition checking that was invalid and was not matching to the comment above.
>  
> Could someone please review and commit if valid ?
>  
> Thanks,
> Marianne
> <LoopVectorize.patch>
>  
> <LoopVectorize.patch>
>  
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150624/4229595a/attachment.html>


More information about the llvm-commits mailing list