<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class="">Hi Marianne!</div><div class=""><br class=""></div><div class="">I committed your patch in <span style="font-family: 'Helvetica Neue'; line-height: normal;" class="">r240556 </span>with a small change in the test:</div><div class="">-; RUN: opt < %s -loop-vectorize -O2 -debug -S 2>&1 | FileCheck %s</div><div class="">+; REQUIRES: asserts</div><div class="">+; RUN: opt < %s -loop-vectorize -Os -debug -debug-only=loop-vectorize -S 2>&1 | FileCheck %s</div></div><div class=""><br class=""></div><div class="">Thanks for fixing it!</div><div class=""><br class=""></div><div class="">Michael</div><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 23, 2015, at 6:34 AM, Marianne Mailhot-Sarrasin <<a href="mailto:marianne.mailhot-sarrasin@octasic.com" class="">marianne.mailhot-sarrasin@octasic.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class="">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)" class="">
<style class=""><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div lang="EN-CA" link="blue" vlink="purple" class="">
<div class="WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Thanks. Could you please commit it ?<o:p class=""></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Marianne<o:p class=""></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></p>
<div class="">
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm" class=""><p class="MsoNormal"><b class=""><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class=""> Nadav Rotem [<a href="mailto:nrotem@apple.com" class="">mailto:nrotem@apple.com</a>]
<br class="">
<b class="">Sent:</b> June-22-15 6:25 PM<br class="">
<b class="">To:</b> Marianne Mailhot-Sarrasin<br class="">
<b class="">Cc:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<b class="">Subject:</b> Re: [PATCH] [LoopVectorize] Detect correctly if vectorizer will create a tail loop<o:p class=""></o:p></span></p>
</div>
</div><p class="MsoNormal"><o:p class=""> </o:p></p>
<div class=""><p class="MsoNormal">Looks good to me. <o:p class=""></o:p></p>
</div>
<div class=""><p class="MsoNormal"><o:p class=""> </o:p></p>
</div>
<div class=""><p class="MsoNormal"><o:p class=""> </o:p></p>
<div class="">
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt" class="">
<div class=""><p class="MsoNormal">On Jun 22, 2015, at 12:17 PM, Marianne Mailhot-Sarrasin <<a href="mailto:marianne.mailhot-sarrasin@octasic.com" class="">marianne.mailhot-sarrasin@octasic.com</a>> wrote:<o:p class=""></o:p></p>
</div><p class="MsoNormal"><o:p class=""> </o:p></p>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">I have added it in the patch.</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""><o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""><o:p class=""></o:p></span></p>
</div>
<div class="">
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm" class="">
<div class=""><p class="MsoNormal" style="line-height:10.5pt"><b class=""><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="">From:</span></b><span class="apple-converted-space"><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class=""> </span></span><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="">Nadav
Rotem [<a href="mailto:nrotem@apple.com" class=""><span style="color:purple" class="">mailto:nrotem@apple.com</span></a>]<span class="apple-converted-space"> </span><br class="">
<b class="">Sent:</b><span class="apple-converted-space"> </span>June-22-15 1:21 PM<br class="">
<b class="">To:</b><span class="apple-converted-space"> </span>Marianne Mailhot-Sarrasin<br class="">
<b class="">Cc:</b><span class="apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" class=""><span style="color:purple" class="">llvm-commits@cs.uiuc.edu</span></a><br class="">
<b class="">Subject:</b><span class="apple-converted-space"> </span>Re: [PATCH] [LoopVectorize] Detect correctly if vectorizer will create a tail loop</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""><o:p class=""></o:p></span></p>
</div>
</div>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Hi Marianne, <o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Can you please provide a testcase for this fix?<o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Thanks,<o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Nadav<o:p class=""></o:p></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class="">
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt" class="">
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">On Jun 22, 2015, at 7:01 AM, Marianne Mailhot-Sarrasin <<a href="mailto:marianne.mailhot-sarrasin@octasic.com" class=""><span style="color:purple" class="">marianne.mailhot-sarrasin@octasic.com</span></a>>
wrote:<o:p class=""></o:p></span></p>
</div>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class="">
<div class="">
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Hi,<o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Here is a simple bug fix. With option OptForSize enabled, the Loop Vectorizer is not supposed to create tail loop. The condition checking
that was invalid and was not matching to the comment above.<o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Could someone please review and commit if valid ?<o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""> <o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Thanks,<o:p class=""></o:p></span></p>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class="">Marianne<o:p class=""></o:p></span></p>
</div>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"><LoopVectorize.patch><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""><o:p class=""></o:p></span></p>
</div>
</div>
</blockquote>
</div>
<div class=""><p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" class=""><o:p class=""></o:p></span></p>
</div><p class="MsoNormal"><LoopVectorize.patch><o:p class=""></o:p></p>
</div>
</blockquote>
</div><p class="MsoNormal"><o:p class=""> </o:p></p>
</div>
</div>
</div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>