[PATCH] Adding altmacro support in integrated assembler.
michael zuckerman
michael.zuckerman at intel.com
Wed Jun 24 08:02:16 PDT 2015
rebase in :
This is the new review: http://reviews.llvm.org/D10692
================
Comment at: include/llvm/MC/MCParser/AsmLexer.h:58
@@ -57,1 +57,3 @@
private:
+ /// isAtString check if the next token is <string> type or arithmetic.
+ /// string that begin with char '<' must to end with char '>' otherwise it is no a string.
----------------
rafael wrote:
> Don't repeat name in comment.
accept
================
Comment at: lib/MC/MCParser/AsmLexer.cpp:427
@@ +426,3 @@
+ break;
+ if ((CurChar == ',') || (CurChar == '\n')){
+ CurPtr--;
----------------
rafael wrote:
> What is this for? Is <> delimited strings only valid if followed by , or newline?!
>
for the <>I use the same output as the "" of llvm use empty string
**example:**
run: llvm-mc filename.asm
.altmacro
.macro mksym, name, number
.long \name\number
.long \name
.endm
mksym "",1
mksym <>,2
output
.text
.long 1
.long 2
http://reviews.llvm.org/D10591
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list