[PATCH] Adding altmacro support in integrated assembler.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Jun 23 08:14:50 PDT 2015


I tried applying the patch on current trunk but it fails. Please rebase.


================
Comment at: include/llvm/MC/MCParser/AsmLexer.h:58
@@ -57,1 +57,3 @@
 private:
+	/// isAtString check if the next token is <string> type or arithmetic.
+	/// string that begin with char '<' must to end with char '>' otherwise it is no a string. 
----------------
Don't repeat name in comment.

================
Comment at: lib/MC/MCParser/AsmLexer.cpp:427
@@ +426,3 @@
+				break;
+			if ((CurChar == ',') || (CurChar == '\n')){
+				CurPtr--;
----------------
What is this for? Is <> delimited strings only valid if followed by , or newline?!

http://reviews.llvm.org/D10591

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list