[llvm] r239805 - Disable llvm/test/CodeGen/MIR/machine-function.mir on x86 msc18 for now. Investigating.

[Alex L]

2015-06-16 16:00 GMT-07:00 Alex L <arphaman at gmail.com>:

> Thanks, I missed this.
>
> I think the emitted MIR differs from the input MIR because the optional
> attributes like exposesReturnTwice, etc. aren't specified in the first two
> functions. The YAML input class should set them those attributes to default
> values for that type, as specified in LLVM's YAML documentation. But this
> isn't happening here for some reason.
>
> I think the Yaml Input class has a bug where it doesn't actually
> initialize the optional values, so hopefully fixing that should solve the
> problem.
>
> Alex.
>
> 2015-06-16 15:37 GMT-07:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:
>
>> +alex
>>
>> > On 2015-Jun-15, at 23:57, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> >
>> > Author: chapuni
>> > Date: Tue Jun 16 01:57:35 2015
>> > New Revision: 239805
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=239805&view=rev
>> > Log:
>> > Disable llvm/test/CodeGen/MIR/machine-function.mir on x86 msc18 for
>> now. Investigating.
>>
>

I fixed the YAML bug in r239972, so I will revert this commit and hopefully
the test will work as expected.

Cheers,
Alex


> >
>> > The emission was as below;
>> >
>> >  ---
>> >  name:            foo
>> >  alignment:       31428584
>> >  exposesReturnsTwice: true
>> >  hasInlineAsm:    false
>> >  ...
>> >  ---
>> >  name:            bar
>> >  alignment:       1701667182
>> >  exposesReturnsTwice: false
>> >  hasInlineAsm:    false
>> >  ...
>> >  ---
>> >  name:            func
>> >  alignment:       8
>> >  exposesReturnsTwice: false
>> >  hasInlineAsm:    false
>> >  ...
>> >  ---
>> >  name:            func2
>> >  alignment:       16
>> >  exposesReturnsTwice: true
>> >  hasInlineAsm:    true
>> >  ...
>> >
>> > Modified:
>> >    llvm/trunk/test/CodeGen/MIR/machine-function.mir
>> >
>> > Modified: llvm/trunk/test/CodeGen/MIR/machine-function.mir
>> > URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/machine-function.mir?rev=239805&r1=239804&r2=239805&view=diff
>> >
>> ==============================================================================
>> > --- llvm/trunk/test/CodeGen/MIR/machine-function.mir (original)
>> > +++ llvm/trunk/test/CodeGen/MIR/machine-function.mir Tue Jun 16
>> 01:57:35 2015
>> > @@ -1,5 +1,6 @@
>> > # RUN: llc -start-after branch-folder -stop-after branch-folder -o
>> /dev/null %s | FileCheck %s
>> > # This test ensures that the MIR parser parses machine functions
>> correctly.
>> > +# REQUIRES: shell
>> >
>> > --- |
>> >
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150617/3e987bfa/attachment.html>