<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-06-16 16:00 GMT-07:00 Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Thanks, I missed this.<div><br></div><div>I think the emitted MIR differs from the input MIR because the optional attributes like exposesReturnTwice, etc. aren't specified in the first two functions. The YAML input class should set them those attributes to default values for that type, as specified in LLVM's YAML documentation. But this isn't happening here for some reason.</div><div><br></div><div>I think the Yaml Input class has a bug where it doesn't actually initialize the optional values, so hopefully fixing that should solve the problem.</div><span class=""><font color="#888888"><div><br></div><div>Alex. </div></font></span></div><div class=""><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2015-06-16 15:37 GMT-07:00 Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+alex<br>
<div><div><br>
> On 2015-Jun-15, at 23:57, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>> wrote:<br>
><br>
> Author: chapuni<br>
> Date: Tue Jun 16 01:57:35 2015<br>
> New Revision: 239805<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239805-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Nf1n5bwm6Lrrv7alKzgRpeP3PAB53GPde8O5j1-ukHY&s=tDT9wGmjlaU4HsihyyRuq5SsYwvUpWwCSSRlrer92k8&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239805&view=rev</a><br>
> Log:<br>
> Disable llvm/test/CodeGen/MIR/machine-function.mir on x86 msc18 for now. Investigating.<br></div></div></blockquote></div></div></div></div></blockquote><div><br></div><div><br></div><div>I fixed the YAML bug in r239972, so I will revert this commit and hopefully the test will work as expected.<div><br></div><div>Cheers,</div><div>Alex</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>
><br>
> The emission was as below;<br>
><br>
>  ---<br>
>  name:            foo<br>
>  alignment:       31428584<br>
>  exposesReturnsTwice: true<br>
>  hasInlineAsm:    false<br>
>  ...<br>
>  ---<br>
>  name:            bar<br>
>  alignment:       1701667182<br>
>  exposesReturnsTwice: false<br>
>  hasInlineAsm:    false<br>
>  ...<br>
>  ---<br>
>  name:            func<br>
>  alignment:       8<br>
>  exposesReturnsTwice: false<br>
>  hasInlineAsm:    false<br>
>  ...<br>
>  ---<br>
>  name:            func2<br>
>  alignment:       16<br>
>  exposesReturnsTwice: true<br>
>  hasInlineAsm:    true<br>
>  ...<br>
><br>
> Modified:<br>
>    llvm/trunk/test/CodeGen/MIR/machine-function.mir<br>
><br>
> Modified: llvm/trunk/test/CodeGen/MIR/machine-function.mir<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_CodeGen_MIR_machine-2Dfunction.mir-3Frev-3D239805-26r1-3D239804-26r2-3D239805-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Nf1n5bwm6Lrrv7alKzgRpeP3PAB53GPde8O5j1-ukHY&s=-icrReNDiFBlDVsG9LU7CkpOfjl2TmfenqeGJE4ydIE&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/machine-function.mir?rev=239805&r1=239804&r2=239805&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/CodeGen/MIR/machine-function.mir (original)<br>
> +++ llvm/trunk/test/CodeGen/MIR/machine-function.mir Tue Jun 16 01:57:35 2015<br>
> @@ -1,5 +1,6 @@<br>
> # RUN: llc -start-after branch-folder -stop-after branch-folder -o /dev/null %s | FileCheck %s<br>
> # This test ensures that the MIR parser parses machine functions correctly.<br>
> +# REQUIRES: shell<br>
><br>
> --- |<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>