[PATCH] LTO: expose LTO_SYMBOL_COMDAT flag, which indicates that the definition is part of a comdat group.

[Rafael Espíndola]

Lgtm
On Jun 11, 2015 5:22 PM, "Peter Collingbourne" <peter at pcc.me.uk> wrote:

> Make COMDAT flag orthogonal to definition
>
>
> http://reviews.llvm.org/D10330
>
> Files:
>   include/llvm-c/lto.h
>   lib/LTO/LTOModule.cpp
>
> Index: include/llvm-c/lto.h
> ===================================================================
> --- include/llvm-c/lto.h
> +++ include/llvm-c/lto.h
> @@ -62,7 +62,8 @@
>      LTO_SYMBOL_SCOPE_HIDDEN                = 0x00001000,
>      LTO_SYMBOL_SCOPE_PROTECTED             = 0x00002000,
>      LTO_SYMBOL_SCOPE_DEFAULT               = 0x00001800,
> -    LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN = 0x00002800
> +    LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN = 0x00002800,
> +    LTO_SYMBOL_COMDAT                      = 0x00004000
>  } lto_symbol_attributes;
>
>  /**
> Index: lib/LTO/LTOModule.cpp
> ===================================================================
> --- lib/LTO/LTOModule.cpp
> +++ lib/LTO/LTOModule.cpp
> @@ -468,6 +468,9 @@
>    else
>      attr |= LTO_SYMBOL_SCOPE_DEFAULT;
>
> +  if (def->hasComdat())
> +    attr |= LTO_SYMBOL_COMDAT;
> +
>    auto Iter = _defines.insert(Name).first;
>
>    // fill information structure
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150611/22a49fe5/attachment.html>