<p dir="ltr">Lgtm </p>
<div class="gmail_quote">On Jun 11, 2015 5:22 PM, "Peter Collingbourne" <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Make COMDAT flag orthogonal to definition<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10330&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ysbx6Fc5SyTc3FSadc6tojOENhYFsX_alx8YE2gLEtM&s=KXCPsj2V2OXr1bzEuyQ4HLyDe0AVxShrzXdP9PT2pjA&e=" target="_blank">http://reviews.llvm.org/D10330</a><br>
<br>
Files:<br>
  include/llvm-c/lto.h<br>
  lib/LTO/LTOModule.cpp<br>
<br>
Index: include/llvm-c/lto.h<br>
===================================================================<br>
--- include/llvm-c/lto.h<br>
+++ include/llvm-c/lto.h<br>
@@ -62,7 +62,8 @@<br>
     LTO_SYMBOL_SCOPE_HIDDEN                = 0x00001000,<br>
     LTO_SYMBOL_SCOPE_PROTECTED             = 0x00002000,<br>
     LTO_SYMBOL_SCOPE_DEFAULT               = 0x00001800,<br>
-    LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN = 0x00002800<br>
+    LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN = 0x00002800,<br>
+    LTO_SYMBOL_COMDAT                      = 0x00004000<br>
 } lto_symbol_attributes;<br>
<br>
 /**<br>
Index: lib/LTO/LTOModule.cpp<br>
===================================================================<br>
--- lib/LTO/LTOModule.cpp<br>
+++ lib/LTO/LTOModule.cpp<br>
@@ -468,6 +468,9 @@<br>
   else<br>
     attr |= LTO_SYMBOL_SCOPE_DEFAULT;<br>
<br>
+  if (def->hasComdat())<br>
+    attr |= LTO_SYMBOL_COMDAT;<br>
+<br>
   auto Iter = _defines.insert(Name).first;<br>
<br>
   // fill information structure<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ysbx6Fc5SyTc3FSadc6tojOENhYFsX_alx8YE2gLEtM&s=VK4jRrb5_UIYSAzhIqK8t733XCpwUMkUv7eBT_CrLZM&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div>