[PATCH] [ASan] Test churn for setting ASAN_OPTIONS=symbolize_vs_style=false

[Filipe Cabecinhas]

(I said on IRC, but I'll repeat to have it included in the thread)

env ASAN_OPTIONS+=blah=true
doesn't work on Windows, unfortunately.

I can change it to either (I think any of these would be preferable to the
current patch):
  - use Reid's idea of making a (yet another) single purpose utility
(llvm-env)
  - use expansion (ASAN_OPTIONS=$ASAN_OPTIONS:...) instead of spelling out
symbolize_vs_style=true again (I didn't think about this one)
  - change lit's shell, if we're sure that's the one that's being used.

Thanks,

  Filipe

On Tue, Jun 9, 2015 at 5:22 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

> Wait a second, why can't you set
>
>   config.environment['ASAN_OPTIONS'] = 'symbolize_vs_style=false'
>
> in lit configs, and then use `ASAN_OPTIONS+=` or
> `ASAN_OPTIONS=$ASAN_OPTIONS:<....>` in the tests which set this env
> variable?
> In this case you won't have to update all the test cases every time you
> want to set the default value of certain runtime flag for the test suite.
>
>
> http://reviews.llvm.org/D10294
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/dcf47ff7/attachment.html>