<div dir="ltr">(I said on IRC, but I'll repeat to have it included in the thread)<div><br></div><div>env ASAN_OPTIONS+=blah=true</div><div>doesn't work on Windows, unfortunately.</div><div><br></div><div>I can change it to either (I think any of these would be preferable to the current patch):</div><div>  - use Reid's idea of making a (yet another) single purpose utility (llvm-env)</div><div>  - use expansion (ASAN_OPTIONS=$ASAN_OPTIONS:...) instead of spelling out symbolize_vs_style=true again (I didn't think about this one)</div><div>  - change lit's shell, if we're sure that's the one that's being used.<br><div><br></div><div>Thanks,</div><div><br></div><div>  Filipe<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 5:22 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Wait a second, why can't you set<br>
<br>
  config.environment['ASAN_OPTIONS'] = 'symbolize_vs_style=false'<br>
<br>
in lit configs, and then use `ASAN_OPTIONS+=` or `ASAN_OPTIONS=$ASAN_OPTIONS:<....>` in the tests which set this env variable?<br>
In this case you won't have to update all the test cases every time you want to set the default value of certain runtime flag for the test suite.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10294&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=XPfjcmUb50rby5hqTGQHqJmq0NiYo6W0BFCWCd5WFV4&s=hWiYnzu0fIZePEkjVXRd6qjxn_tsZLBTflKDPpavXuI&e=" target="_blank">http://reviews.llvm.org/D10294</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=XPfjcmUb50rby5hqTGQHqJmq0NiYo6W0BFCWCd5WFV4&s=CBRw-ty-09s_yuNKuFiZxyK7sTz-vjXN_U_4IjF-SnY&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div></div></div>