[PATCH] LibDriver, llvm-lib: introduce.

Rui Ueyama ruiu at google.com
Tue Jun 9 14:56:05 PDT 2015


2015/06/09 午後2:31 "Rafael Ávila de Espíndola" <rafael.espindola at gmail.com>:
>
> This is fine from the llvm side.
>
> Rui, is this a convenient interface for lld to use?
>
>
> ================
> Comment at: lib/LibDriver/LibDriver.cpp:71
> @@ +70,3 @@
> +namespace {
> +class StrDupSaver : public cl::StringSaver {
> +  std::vector<char *> Dups;
> ----------------
> We really should just move the string saver that rui implemented to llvm
and make it the one true string saver.
> At least add a fixme about that.

Let me do that. I'll send a patch later.

>
> http://reviews.llvm.org/D10297
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/0f8a3ba3/attachment.html>


More information about the llvm-commits mailing list