<p dir="ltr"><br>
2015/06/09 午後2:31 "Rafael Ávila de Espíndola" <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>>:<br>
><br>
> This is fine from the llvm side.<br>
><br>
> Rui, is this a convenient interface for lld to use?<br>
><br>
><br>
> ================<br>
> Comment at: lib/LibDriver/LibDriver.cpp:71<br>
> @@ +70,3 @@<br>
> +namespace {<br>
> +class StrDupSaver : public cl::StringSaver {<br>
> +  std::vector<char *> Dups;<br>
> ----------------<br>
> We really should just move the string saver that rui implemented to llvm and make it the one true string saver.<br>
> At least add a fixme about that.</p>
<p dir="ltr">Let me do that. I'll send a patch later.</p>
<p dir="ltr">><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10297&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=hPGEdjDb7Zb8omH2ytRDKpClMIe8sY0UiiItySkOmuU&s=GTgAVIkmly18Q3ynkLHj7dCkwq0YvlZLKBxch0_Amzg&e=">http://reviews.llvm.org/D10297</a><br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=hPGEdjDb7Zb8omH2ytRDKpClMIe8sY0UiiItySkOmuU&s=FWtEVduc2Roj2G85n_Q8RaNOLSM7i6-VuWe3xhyxexM&e=">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
><br>
</p>