[PATCH] Don't use ManagedStatic.

[Rui Ueyama]

On Mon, Jun 8, 2015 at 7:45 PM, Sean Silva <chisophugis at gmail.com> wrote:

> What is calling object::object_category so much that it can occupy 9% of
> the run time? If that code path is sufficiently common maybe it should just
> not be using "errors" in the first place.


Good point. There are many places in include/llvm/Object where we return
object_error::success. That seems the cause of this problem.

Maybe we should remove object_error::success and use std::error_code
instead.

Any objection?


> Overall, just relying on thread-safe statics is preferable, but even then
> having so many non-inlined calls to this function in regular operation
> doesn't seem right.
>
>
> http://reviews.llvm.org/D10303
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150608/51c12ec6/attachment.html>