<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 8, 2015 at 7:45 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">What is calling object::object_category so much that it can occupy 9% of the run time? If that code path is sufficiently common maybe it should just not be using "errors" in the first place.</blockquote><div><br></div><div>Good point. There are many places in include/llvm/Object where we return object_error::success. That seems the cause of this problem.</div><div><br></div><div>Maybe we should remove object_error::success and use std::error_code instead.</div><div><br></div><div>Any objection?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Overall, just relying on thread-safe statics is preferable, but even then having so many non-inlined calls to this function in regular operation doesn't seem right.<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10303&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=loLMHAZoaA3wuamzXJAHWE44A6Sp1LzKkPS_ENvH36g&s=r9ZwXu5Qkwr0NpFpWft5e52Fc1s4bqzBvG5xt-uCVVc&e=" target="_blank">http://reviews.llvm.org/D10303</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=loLMHAZoaA3wuamzXJAHWE44A6Sp1LzKkPS_ENvH36g&s=P5yhX21VqXw9TYK_HTMdHlvV-srKei8zlPWpa_PddfU&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div><br></div></div>