[llvm] r239053 - R600/SI: Reimplement isLegalAddressingMode

[Reid Kleckner]

Yeah, that's the usual solution. I went ahead and did that in r239355.

On Mon, Jun 8, 2015 at 3:18 PM, Matt Arsenault <Matthew.Arsenault at amd.com>
wrote:

>  On 06/08/2015 02:37 PM, Reid Kleckner wrote:
>
> This broke the Windows self-host:
> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/1279
>
>  +  // Some places use this if the address space can't be determined.
> +  UNKNOWN_ADDRESS_SPACE = ~0u
>
>  On Windows, enums are always ints unless you say otherwise, so clang-cl
> gave us this:
>
>  ..\lib\Target\R600/AMDGPU.h(143,3) :  warning: enumerator value is not
> representable in the underlying type 'int' [-Wmicrosoft]
>   UNKNOWN_ADDRESS_SPACE = ~0u
>   ^
> ..\lib\Target\R600\SIISelLowering.cpp(263,8) :  error: case value
> evaluates to -1, which cannot be narrowed to type 'unsigned int'
> [-Wc++11-narrowing]
>   case AMDGPUAS::UNKNOWN_ADDRESS_SPACE: {
>        ^
>
> Can we use the C++11 feature to specify the enum type?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150608/c457e599/attachment.html>