<div dir="ltr">Yeah, that's the usual solution. I went ahead and did that in r239355.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 8, 2015 at 3:18 PM, Matt Arsenault <span dir="ltr"><<a href="mailto:Matthew.Arsenault@amd.com" target="_blank">Matthew.Arsenault@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<div>On 06/08/2015 02:37 PM, Reid Kleckner
wrote:<br>
</div>
<blockquote type="cite">This broke the Windows self-host:
<div><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dx86-2Dwin2008-2Dselfhost_builds_1279&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=YPRBs8gq5lP7y95yFCAZzNbNik8RilN2swClG_J8TLc&s=9polmn8fNALlja2I2CzQ7tV-JM0t4sDljgDUzX1h9eA&e=" target="_blank">http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/1279</a><br>
</div>
<div><br>
</div>
<div><span style="font-size:12.8000001907349px">+ // Some places
use this if the address space can't be determined.</span><br style="font-size:12.8000001907349px">
<span style="font-size:12.8000001907349px">+
UNKNOWN_ADDRESS_SPACE = ~0u</span><br>
</div>
<div><span style="font-size:12.8000001907349px"><br>
</span></div>
<div><span style="font-size:12.8000001907349px">On Windows, enums
are always ints unless you say otherwise, so clang-cl gave us
this:</span></div>
<div><span style="font-size:12.8000001907349px"><br>
</span></div>
<div>
<div><span style="font-size:12.8000001907349px">..\lib\Target\R600/AMDGPU.h(143,3)
: warning: enumerator value is not representable in the
underlying type 'int' [-Wmicrosoft]</span></div>
<div><span style="font-size:12.8000001907349px">
UNKNOWN_ADDRESS_SPACE = ~0u</span></div>
<div><span style="font-size:12.8000001907349px"> ^</span></div>
<div><span style="font-size:12.8000001907349px">..\lib\Target\R600\SIISelLowering.cpp(263,8)
: error: case value evaluates to -1, which cannot be
narrowed to type 'unsigned int' [-Wc++11-narrowing]</span></div>
<div><span style="font-size:12.8000001907349px"> case
AMDGPUAS::UNKNOWN_ADDRESS_SPACE: {</span></div>
<div><span style="font-size:12.8000001907349px">
^</span></div>
</div>
</blockquote></span>
Can we use the C++11 feature to specify the enum type?<br>
</div>
</blockquote></div><br></div>