[PATCH] [DebugInfo][FastISel] Prevent using debug location from previous block for local values

[David Blaikie]

On Thu, May 21, 2015 at 7:08 AM, Sergey Dmitrouk <sdmitrouk at accesssoftek.com
> wrote:

> Thanks to Fred I see that this is basically the same as an old patch (
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120917/151433.html)
> related to the bug of the same age (
> https://llvm.org/bugs/show_bug.cgi?id=14501), which was unfortunately
> rejected... Still pulled in Pauls nice test case and added missing changes
> here. I would prefer to have some kind of fix rather than have obviously
> wrong locations (provided that we don't make anything worse that it is at
> the moment).
>

Might be worth pinging the original thread to provide the full context or
continue the discussion there (the mailing list archives are bad at
navigating the full context since they chunk it up into monthly pages - so
I can't see any replies to that patch review email, for example).

It's a bit problematic to continue to add workarounds on top of workarounds
- makes the code harder to maintain, etc. So there's something to be said
for considering what the "right" approach, if any, might be and how much it
would cost before we do this.

- David


>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D9887
>
> Files:
>   include/llvm/CodeGen/FastISel.h
>   lib/CodeGen/SelectionDAG/FastISel.cpp
>   lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
>   test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll
>   test/DebugInfo/X86/dbg-line-fast-isel.ll
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150608/04758561/attachment.html>