<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 21, 2015 at 7:08 AM, Sergey Dmitrouk <span dir="ltr"><<a href="mailto:sdmitrouk@accesssoftek.com" target="_blank">sdmitrouk@accesssoftek.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks to Fred I see that this is basically the same as an old patch (<a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120917/151433.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120917/151433.html</a>) related to the bug of the same age (<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_show-5Fbug.cgi-3Fid-3D14501&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=9-U79iPB3edgtMsapmxCqNjaR-LTYy9dQHlEqYf58f8&s=A_fUbFN5i7HvGLyoFp8sZISSKE6kO_UpuDEWfB0ytto&e=" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=14501</a>), which was unfortunately rejected... Still pulled in Pauls nice test case and added missing changes here. I would prefer to have some kind of fix rather than have obviously wrong locations (provided that we don't make anything worse that it is at the moment).<br></blockquote><div><br>Might be worth pinging the original thread to provide the full context or continue the discussion there (the mailing list archives are bad at navigating the full context since they chunk it up into monthly pages - so I can't see any replies to that patch review email, for example).<br><br>It's a bit problematic to continue to add workarounds on top of workarounds - makes the code harder to maintain, etc. So there's something to be said for considering what the "right" approach, if any, might be and how much it would cost before we do this.<br><br>- David<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9887&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=9-U79iPB3edgtMsapmxCqNjaR-LTYy9dQHlEqYf58f8&s=g368SX_E_tdkF713aIhhJZwSa4USBqm4cLIMl8Vyt_Y&e=" target="_blank">http://reviews.llvm.org/D9887</a><br>
<br>
Files:<br>
  include/llvm/CodeGen/FastISel.h<br>
  lib/CodeGen/SelectionDAG/FastISel.cpp<br>
  lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>
  test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll<br>
</span>  test/DebugInfo/X86/dbg-line-fast-isel.ll<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=9-U79iPB3edgtMsapmxCqNjaR-LTYy9dQHlEqYf58f8&s=ZBg9LCAT4pLd11rgbN9KT0L8b8SGBapcqa3r4h_WJdU&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div><br></div></div>