[llvm] r239231 - [Object/ELF] Provide helpers for symbol types.
Davide Italiano
davide at freebsd.org
Sat Jun 6 19:41:39 PDT 2015
On Sat, Jun 6, 2015 at 7:34 PM, Rafael EspĂndola
<rafael.espindola at gmail.com> wrote:
>> + bool isCommon() const {
>> + return !isUndefined() &&
>> + !(st_shndx >= ELF::SHN_LORESERVE && st_shndx < ELF::SHN_ABS);
>> + }
>
> I think there was a misunderstanding. isCommon sounds like SHN_COMMON.
> The above code is actually isDefined :-)
>
This is what happens when you send something for review, test it, than
modify it 30 seconds before committing.
Pointy-hat to me.
More information about the llvm-commits
mailing list