[llvm] r239231 - [Object/ELF] Provide helpers for symbol types.

[Rafael Espíndola]

> +  bool isCommon() const {
> +    return !isUndefined() &&
> +           !(st_shndx >= ELF::SHN_LORESERVE && st_shndx < ELF::SHN_ABS);
> +  }

I think there was a misunderstanding. isCommon sounds like SHN_COMMON.
The above code is actually isDefined :-)

> +  bool isDefined() const {
> +    return !isUndefined() &&
> +           (!(st_shndx >= ELF::SHN_LORESERVE &&
> +              st_shndx <= ELF::SHN_HIRESERVE) ||
> +            st_shndx == ELF::SHN_XINDEX);
> +  }
> +  bool isProcessorSpecific() const {
> +    return st_shndx >= ELF::SHN_LOPROC && st_shndx <= ELF::SHN_HIPROC;
> +  }
> +  bool isOSSpecific() const {
> +    return st_shndx >= ELF::SHN_LOOS && st_shndx <= ELF::SHN_HIOS;
> +  }
> +  bool isReserved() const {
> +    return st_shndx > ELF::SHN_HIOS && st_shndx < ELF::SHN_ABS;
> +  }
> +  bool isUndefined() const { return st_shndx == ELF::SHN_UNDEF; }
>  };
>
>  /// Elf_Versym: This is the structure of entries in the SHT_GNU_versym section
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits