[llvm] r239158 - [TargetParser] Properly attach functions of ARMTargetParser to the class

[David Blaikie]

On Fri, Jun 5, 2015 at 7:33 AM, Benjamin Kramer <benny.kra at googlemail.com>
wrote:

> Author: d0k
> Date: Fri Jun  5 09:33:02 2015
> New Revision: 239158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=239158&view=rev
> Log:
> [TargetParser] Properly attach functions of ARMTargetParser to the class
>

How did these functions work previously? If they can be non-members, should
they just remain that way? (I assume not, because I saw you made a change
like that in another commit & I expect there's a reason it wasn't
applicable here - just can't see it from the diff alone)


>
> Modified:
>     llvm/trunk/lib/Support/TargetParser.cpp
>
> Modified: llvm/trunk/lib/Support/TargetParser.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/TargetParser.cpp?rev=239158&r1=239157&r2=239158&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Support/TargetParser.cpp (original)
> +++ llvm/trunk/lib/Support/TargetParser.cpp Fri Jun  5 09:33:02 2015
> @@ -223,8 +223,6 @@ struct {
>
>  } // namespace
>
> -namespace llvm {
> -
>  // ======================================================= //
>  // Information by ID
>  // ======================================================= //
> @@ -241,13 +239,13 @@ unsigned ARMTargetParser::getFPUVersion(
>    return FPUNames[FPUKind].FPUVersion;
>  }
>
> -unsigned getFPUNeonSupportLevel(unsigned FPUKind) {
> +unsigned ARMTargetParser::getFPUNeonSupportLevel(unsigned FPUKind) {
>    if (FPUKind >= ARM::FK_LAST)
>      return 0;
>    return FPUNames[FPUKind].NeonSupport;
>  }
>
> -unsigned getFPURestriction(unsigned FPUKind) {
> +unsigned ARMTargetParser::getFPURestriction(unsigned FPUKind) {
>    if (FPUKind >= ARM::FK_LAST)
>      return 0;
>    return FPUNames[FPUKind].Restriction;
> @@ -587,5 +585,3 @@ unsigned ARMTargetParser::parseArchVersi
>    }
>    return 0;
>  }
> -
> -} // namespace llvm
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150605/42956427/attachment.html>