<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 5, 2015 at 7:33 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Jun  5 09:33:02 2015<br>
New Revision: 239158<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239158-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=bYLmdtQoxQZkJXynr60Jt6TpY9lWBC7Rf9JtJCE_dZo&s=A0KjchdSNi3ZRstuXDFq_UlMWyO1pvf38iB6i2joHaI&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239158&view=rev</a><br>
Log:<br>
[TargetParser] Properly attach functions of ARMTargetParser to the class<br></blockquote><div><br>How did these functions work previously? If they can be non-members, should they just remain that way? (I assume not, because I saw you made a change like that in another commit & I expect there's a reason it wasn't applicable here - just can't see it from the diff alone)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/Support/TargetParser.cpp<br>
<br>
Modified: llvm/trunk/lib/Support/TargetParser.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Support_TargetParser.cpp-3Frev-3D239158-26r1-3D239157-26r2-3D239158-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=bYLmdtQoxQZkJXynr60Jt6TpY9lWBC7Rf9JtJCE_dZo&s=vu1rNi7_dq3p32C2b_vuayodvvJXZtp05RdCOMAd0jM&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/TargetParser.cpp?rev=239158&r1=239157&r2=239158&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Support/TargetParser.cpp (original)<br>
+++ llvm/trunk/lib/Support/TargetParser.cpp Fri Jun  5 09:33:02 2015<br>
@@ -223,8 +223,6 @@ struct {<br>
<br>
 } // namespace<br>
<br>
-namespace llvm {<br>
-<br>
 // ======================================================= //<br>
 // Information by ID<br>
 // ======================================================= //<br>
@@ -241,13 +239,13 @@ unsigned ARMTargetParser::getFPUVersion(<br>
   return FPUNames[FPUKind].FPUVersion;<br>
 }<br>
<br>
-unsigned getFPUNeonSupportLevel(unsigned FPUKind) {<br>
+unsigned ARMTargetParser::getFPUNeonSupportLevel(unsigned FPUKind) {<br>
   if (FPUKind >= ARM::FK_LAST)<br>
     return 0;<br>
   return FPUNames[FPUKind].NeonSupport;<br>
 }<br>
<br>
-unsigned getFPURestriction(unsigned FPUKind) {<br>
+unsigned ARMTargetParser::getFPURestriction(unsigned FPUKind) {<br>
   if (FPUKind >= ARM::FK_LAST)<br>
     return 0;<br>
   return FPUNames[FPUKind].Restriction;<br>
@@ -587,5 +585,3 @@ unsigned ARMTargetParser::parseArchVersi<br>
   }<br>
   return 0;<br>
 }<br>
-<br>
-} // namespace llvm<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>