[PATCH] [LLD] COFF: Define error categories for Driver, Reader and Resolver.
Rui Ueyama
ruiu at google.com
Sun May 31 16:05:23 PDT 2015
================
Comment at: COFF/Error.h:21
@@ +20,3 @@
+// Driver errors
+enum class DriverError { Success, InvalidOption };
+
----------------
rafael wrote:
> I don't think you need Success. You can just use std::error_code(), no?
Correct. I'll remove that.
Does it make sense to merge all the error categories into one LLDErrorCategory and let the caller distinguish error type by its value? What do you think?
http://reviews.llvm.org/D10129
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list