[PATCH] [LLD] COFF: Define error categories for Driver, Reader and Resolver.
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Sun May 31 15:06:09 PDT 2015
LGTM, just check if you really need the various ways of saying Success.
================
Comment at: COFF/Error.h:21
@@ +20,3 @@
+// Driver errors
+enum class DriverError { Success, InvalidOption };
+
----------------
I don't think you need Success. You can just use std::error_code(), no?
http://reviews.llvm.org/D10129
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list