[llvm] r238494 - [llvm] Adding vdtor to fix warning.

[David Blaikie]

On Thu, May 28, 2015 at 1:59 PM, Colin LeMahieu <colinl at codeaurora.org>
wrote:

> Author: colinl
> Date: Thu May 28 15:59:08 2015
> New Revision: 238494
>
> URL: http://llvm.org/viewvc/llvm-project?rev=238494&view=rev
> Log:
> [llvm] Adding vdtor to fix warning.
>
> Modified:
>     llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
>
> Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=238494&r1=238493&r2=238494&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
> +++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu May 28 15:59:08 2015
> @@ -204,6 +204,7 @@ bool llvm::RelocAddressLess(RelocationRe
>  namespace {
>  class PrettyPrinter {
>  public:
> +  virtual ~PrettyPrinter(){}
>

Does this type actually need a virtual destructor - is it owned/destroyed
polymorphically? (alternatively, if it is not, prefer a protected
non-virtual dtor, and final derived classes)


>    virtual void printInst(MCInstPrinter &IP, const MCInst *MI, bool
> ShowRawInsn,
>                           ArrayRef<uint8_t> Bytes, uint64_t Address,
>                           raw_ostream &OS, StringRef Annot,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150528/09a56a51/attachment.html>