<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 28, 2015 at 1:59 PM, Colin LeMahieu <span dir="ltr"><<a href="mailto:colinl@codeaurora.org" target="_blank">colinl@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: colinl<br>
Date: Thu May 28 15:59:08 2015<br>
New Revision: 238494<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238494-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=9nir8FLeh5Cjyw0GkN4hn0cvwW2YQwpH1mYxM6MEKR4&s=TkgULR78JuJV-2bKI-c8Z8NQzZBnlR35axlLIuJJrYs&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238494&view=rev</a><br>
Log:<br>
[llvm] Adding vdtor to fix warning.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_tools_llvm-2Dobjdump_llvm-2Dobjdump.cpp-3Frev-3D238494-26r1-3D238493-26r2-3D238494-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=9nir8FLeh5Cjyw0GkN4hn0cvwW2YQwpH1mYxM6MEKR4&s=ef5_XbqcmoxxowmR6cKWJE0jnnq6LszCgjmaiLAIYGY&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=238494&r1=238493&r2=238494&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)<br>
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu May 28 15:59:08 2015<br>
@@ -204,6 +204,7 @@ bool llvm::RelocAddressLess(RelocationRe<br>
 namespace {<br>
 class PrettyPrinter {<br>
 public:<br>
+  virtual ~PrettyPrinter(){}<br></blockquote><div><br>Does this type actually need a virtual destructor - is it owned/destroyed polymorphically? (alternatively, if it is not, prefer a protected non-virtual dtor, and final derived classes)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   virtual void printInst(MCInstPrinter &IP, const MCInst *MI, bool ShowRawInsn,<br>
                          ArrayRef<uint8_t> Bytes, uint64_t Address,<br>
                          raw_ostream &OS, StringRef Annot,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>