[PATCH] [ELF/AArch64] Fix correct TCB aligment calculation

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu May 28 12:22:43 PDT 2015


================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64TargetHandler.h:31-35
@@ +30,7 @@
+      auto sections = this->sections();
+      auto ret = std::max_element(sections.begin(), sections.end(),
+        [](Chunk<ELF64LE> *x, Chunk<ELF64LE> *y)
+          { return x->alignment() < y->alignment(); });
+      _maxAlignment = (*ret)->alignment();
+    }
+    return _maxAlignment;
----------------
This is wrong. You shouldnt be using maximum alignment of **all **sections in the output.

http://reviews.llvm.org/D10088

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list