[PATCH] [ELF/AArch64] Fix correct TCB aligment calculation
Rui Ueyama
ruiu at google.com
Thu May 28 10:22:12 PDT 2015
LGTM
================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64TargetHandler.h:29
@@ +28,3 @@
+ uint64_t maxAlignment() {
+ if (_maxAlignment == 0) {
+ auto sections = this->sections();
----------------
I'd invert the condition to return early.
================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64TargetHandler.h:30
@@ +29,3 @@
+ if (_maxAlignment == 0) {
+ auto sections = this->sections();
+ auto ret = std::max_element(sections.begin(), sections.end(),
----------------
Could you use the actual type instead of auto because the type is not obvious?
http://reviews.llvm.org/D10088
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list