[PATCH] MC: Allow targets to stop symbol name quoting

Rafael Espíndola rafael.espindola at gmail.com
Tue May 26 14:08:06 PDT 2015


I have rebased the patch to take a better look.

On 26 May 2015 at 16:53, Rafael Ávila de Espíndola
<rafael.espindola at gmail.com> wrote:
> Sorry for the delay.
>
> It is looking a lot better, but there are still cases where we are passing a MCAsmInfo and it is not used.
>
>
> ================
> Comment at: lib/MC/MCInst.cpp:18
> @@ -17,3 +17,3 @@
>
> -void MCOperand::print(raw_ostream &OS) const {
> +void MCOperand::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
>    OS << "<MCOperand ";
> ----------------
> This is just for debug, no? You can probably drop the MCAsmInfo from it.
>
> ================
> Comment at: lib/MC/MCInst.cpp:44
> @@ -41,3 +43,3 @@
>
> -void MCInst::print(raw_ostream &OS) const {
> +void MCInst::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
>    OS << "<MCInst " << getOpcode();
> ----------------
> This is just for debug, you can drop the MCAsmInfo.
>
> ================
> Comment at: lib/MC/MCSymbol.cpp:56
> @@ -73,3 +55,3 @@
>  void MCSymbol::dump() const {
> -  print(dbgs());
> +  print(dbgs(), nullptr);
>  }
> ----------------
> This can be just "OS << getName();".
>
> http://reviews.llvm.org/D9207
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch.bz2
Type: application/x-bzip2
Size: 261320 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150526/faca736a/attachment.bin>


More information about the llvm-commits mailing list