[PATCH] MC: Allow targets to stop symbol name quoting
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Tue May 26 13:53:05 PDT 2015
Sorry for the delay.
It is looking a lot better, but there are still cases where we are passing a MCAsmInfo and it is not used.
================
Comment at: lib/MC/MCInst.cpp:18
@@ -17,3 +17,3 @@
-void MCOperand::print(raw_ostream &OS) const {
+void MCOperand::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
OS << "<MCOperand ";
----------------
This is just for debug, no? You can probably drop the MCAsmInfo from it.
================
Comment at: lib/MC/MCInst.cpp:44
@@ -41,3 +43,3 @@
-void MCInst::print(raw_ostream &OS) const {
+void MCInst::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
OS << "<MCInst " << getOpcode();
----------------
This is just for debug, you can drop the MCAsmInfo.
================
Comment at: lib/MC/MCSymbol.cpp:56
@@ -73,3 +55,3 @@
void MCSymbol::dump() const {
- print(dbgs());
+ print(dbgs(), nullptr);
}
----------------
This can be just "OS << getName();".
http://reviews.llvm.org/D9207
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list