[PATCH] reenable gep merging in some constrainted cases

Wei Mi wmi at google.com
Thu May 21 22:46:42 PDT 2015



> Your test cases are quite large, can you please make them a little smaller?


Done.

> +static cl::opt<bool>

>  +    AggressiveGepMerging("aggr-gep-merging", cl::init(false), cl::Hidden,

>  +                         cl::desc("Enable GEP merging for most cases."));

>  +

> 

> - This looks a bit funny, can you clang-format this?


It has already been processed by clang-format.

> Comment at: test/Transforms/InstCombine/gep-merge1.ll:2

>  @@ +1,3 @@

>  +; PR23580

>  +; RUN: opt < %s -O2 -S | FileCheck %s

>  +

> 

> - Please run -instcombine instead of -O2.


I changed -O2 to necessary passes for the test.

Thanks,
Wei.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9865

Files:
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/gep-merge1.ll
  test/Transforms/InstCombine/gep-merge2.ll
  test/Transforms/InstCombine/getelementptr.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9865.26307.patch
Type: text/x-patch
Size: 8655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150522/65f5774e/attachment.bin>


More information about the llvm-commits mailing list