[PATCH] reenable gep merging in some constrainted cases

David Majnemer david.majnemer at gmail.com
Thu May 21 21:06:09 PDT 2015


Your test cases are quite large, can you please make them a little smaller?


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:78-80
@@ -77,1 +77,5 @@
 
+static cl::opt<bool>
+    AggressiveGepMerging("aggr-gep-merging", cl::init(false), cl::Hidden,
+                         cl::desc("Enable GEP merging for most cases."));
+
----------------
This looks a bit funny, can you clang-format this?

================
Comment at: test/Transforms/InstCombine/gep-merge1.ll:2
@@ +1,3 @@
+; PR23580
+; RUN: opt < %s -O2 -S | FileCheck %s
+
----------------
Please run -instcombine instead of -O2.

http://reviews.llvm.org/D9865

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list