[PATCH] AsmParser: Use range check instead of null character check for EOF while tokenizing.

Alex L arphaman at gmail.com
Wed May 20 12:47:09 PDT 2015


I think I'm wrong here actually, while this does work, it's not enough as a
lot of other code in LLLexer as it assumes no range checks.
It would probably be better to go with the original patch with a null
terminating character, as the LLLexer will require a lot of range
checks to be bug free when working with the non-null terminated input.

2015-05-20 12:36 GMT-07:00 Alex Lorenz <arphaman at gmail.com>:

> I updated the patch to use a range check in the LLLexer instead of relying
> on the null character for EOF.
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D9883
>
> Files:
>   lib/AsmParser/LLLexer.cpp
>   unittests/AsmParser/AsmParserTest.cpp
>   unittests/AsmParser/CMakeLists.txt
>   unittests/AsmParser/Makefile
>   unittests/CMakeLists.txt
>   unittests/Makefile
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150520/3737cd79/attachment.html>


More information about the llvm-commits mailing list